Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A (received) Shared Case is displayed as sender/owner #1245

Closed
crackytsi opened this issue Mar 3, 2020 · 8 comments
Closed

A (received) Shared Case is displayed as sender/owner #1245

crackytsi opened this issue Mar 3, 2020 · 8 comments
Assignees
Labels
enhancement TheHive4 TheHive4 related issues
Milestone

Comments

@crackytsi
Copy link

Bug / Feature Request

Work Environment

Question Answer
OS version (server) Debian
OS version (client) 10
TheHive version / git hash 4 RC1
Package Type DEB

Problem Description

A (received) Shared Case is displayed as sender/owner.
This is irritating. Actually its only a received share.
Therefore the option is to delete it, but this fails ("Case sharing update failed")

Steps to Reproduce

  1. Share a case
  2. Check view on the share receiver side.

Possible Solutions

Make a section like "Shared by other organisations"

@crackytsi crackytsi added TheHive4 TheHive4 related issues bug labels Mar 3, 2020
@jeromeleonard
Copy link
Contributor

@crackytsi we need more details please. Does the problem stand in the UI ? Would you prefer to have another indicator to say that the case is "received" ?

@crackytsi
Copy link
Author

My understanding is that if I have OrgA and OrgB the case stays in the Org.
That means CaseA creates a Case, shares it with OrgB.
In this case we see that in OrgA we share Case with OrgB.
("The current case is shared with the following organisation(s): OrgB"

But on OrgB we can also see:
("The current case is shared with the following organisation(s): OrgA"

I would expect a little difference:
("The current case is shared from organisation: OrgA"
instead of
("The current case is shared with the following organisation(s): OrgA"

That was confusing for me.

@jeromeleonard
Copy link
Contributor

Ok I understand. In orgB you can see "Shared from another organisation" in the information label when putting the mouse over the little icon next to the title of the case.
image

Maybe it is not enough.

@jeromeleonard jeromeleonard self-assigned this Mar 11, 2020
@crackytsi
Copy link
Author

This is a screenshot of the (receiving organisation) "shared from"
image

@jeromeleonard
Copy link
Contributor

yes, maybe this part needs for improvement.

@nadouani nadouani self-assigned this Mar 17, 2020
@nadouani nadouani added this to the 4.0.0-RC2 milestone Mar 17, 2020
@nadouani
Copy link
Contributor

This is a screenshot of the (receiving organisation) "shared from"
image

This section can contain multiple shares on that table, if OrgA shares the case with 10 other organisations. So telling you that The current case is shared with the following organisation(s) is meaningful.

We could probably add a visual indicator to highlight the share representing the owner of the case.

@nadouani
Copy link
Contributor

We will try to make it clearer, thanks @crackytsi

@nadouani
Copy link
Contributor

nadouani commented May 4, 2020

We now highlight the owner of the share when displaying the shares list

Screenshot 2020-05-04 at 17 07 23

@nadouani nadouani closed this as completed May 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement TheHive4 TheHive4 related issues
Projects
None yet
Development

No branches or pull requests

3 participants