Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Webhook compatibility issues on custom-fields #1345

Closed
crackytsi opened this issue May 20, 2020 · 5 comments
Closed

[Bug] Webhook compatibility issues on custom-fields #1345

crackytsi opened this issue May 20, 2020 · 5 comments
Assignees
Labels
bug TheHive4 TheHive4 related issues
Milestone

Comments

@crackytsi
Copy link

Request Type

Bug

Work Environment

Question Answer
OS version (server) Debian
OS version (client) 10
TheHive version / git hash 4.0 RC2
Package Type DEB
Elasticsearch 5.6.10

Problem Description

The WebHook of TheHive4 behaves different regarding custom-fields compared to version 3.4:

TheHive 3.x:

	'details': {
		'customFields': {
			'fieldname': {
				'string': 'selected value'
			}
		}
	},

TheHive 4:

	'details': {
		'customField.fieldname': 'selected value'
	},

Also in the "object" the names are different:
TheHive 3.x

		'customFields': {
			'fieldname': {
				'order': 3,
				'string': 'selected value'
			},
		},

TheHive 4:

		'customFields': {
			'fieldname': {
				'string': 'selected value'
			}
		},

The "order" attribute seems also to be missing,
If it is not too much work, it would be great if this could be make compatible :)

@crackytsi crackytsi added TheHive4 TheHive4 related issues bug labels May 20, 2020
@crackytsi
Copy link
Author

@To-om can you fix this also with the upcoming release?

@To-om To-om added this to the 4.0.0-RC3 milestone May 25, 2020
To-om added a commit that referenced this issue May 25, 2020
@To-om To-om closed this as completed May 25, 2020
@crackytsi
Copy link
Author

Thanks so much :) :) :)

@crackytsi
Copy link
Author

@To-om I think there is still something wrong. In TH3 it is customFields with s and not customField (without s)

@To-om
Copy link
Contributor

To-om commented May 26, 2020

You're right ! Nice catch.

@crackytsi
Copy link
Author

@To-om Just to mention it: there is another small difference. That does not play any rule for me (e.g. also works with your python-webhook stubb), so not sure if I should open an issue.

Meanwhile TH3 shows:
'operation': 'Update',
TH4 shows, note the small "U" letter:
'operation': 'update',

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug TheHive4 TheHive4 related issues
Projects
None yet
Development

No branches or pull requests

2 participants