Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] MISP->THEHIVE4 'ExportOnly' and 'Exceptions' ignored in application.conf file #1482

Open
confusedsecuritydudes opened this issue Aug 18, 2020 · 3 comments
Assignees
Labels
bug TheHive4 TheHive4 related issues
Milestone

Comments

@confusedsecuritydudes
Copy link

confusedsecuritydudes commented Aug 18, 2020

Work Environment

Question Answer
OS version (server) Ubuntu 18.04.5 LTS
TheHive version / git hash 4.0.0-1
Package Type DEB

Problem Description

When configuring the connector between TH4 and MISP it appears that the setting in application.conf to 'purpose = ExportOnly' is being ignored. Likewise exclusion {} also appears to have no impact on data ingested into TH4 from MISP.

Steps to Reproduce

  1. Configure /etc/thehive/application.conf
# More information at https://github.com/TheHive-Project/TheHiveDocs/TheHive4/Administration/Connectors.md
# Enable MISP connector
`play.modules.enabled` += org.thp.thehive.connector.misp.MispModule
misp {
 interval: 1 hour
 servers: [
    {
     name = "MISP"            # MISP name
     url = "https://misp.XXXX.XXX" # URL or MISP
     tags = ["misp"]
     
     certpath = false
     caseTemplate = "MISP-EVENT"
     exportCaseTags = true
     max-age = 7 days
     purpose = ExportOnly
    
     exclusion {
        organsation = ["XXXXXX"]
     }

     auth {
       type = key
       key = "XXXXXXXXXXXXXXXXX"             # MISP API key
     }
//     wsConfig {}                        # HTTP client configuration (SSL and proxy)
   }
 ]
}

  1. Restart TheHive.

  2. Alerts still continue to populate TH4 from MISP. Deleting all of the MISP events and clearing alerts is short lives as they all seem to be replaced again (looks like by the same alerts).

Have tried putting the 'purpose' in various places in the config file as well as surrounding "ExportOnly" in quotes but still seems to be ignored.

@confusedsecuritydudes confusedsecuritydudes added TheHive4 TheHive4 related issues bug labels Aug 18, 2020
@nadouani nadouani added this to the 4.0.1 milestone Aug 31, 2020
To-om added a commit that referenced this issue Oct 14, 2020
@To-om To-om closed this as completed Oct 14, 2020
@nadouani nadouani changed the title MISP->THEHIVE4 'ExportOnly' and 'Exceptions' ignored in application.conf file. (BUG) [Bug] MISP->THEHIVE4 'ExportOnly' and 'Exceptions' ignored in application.conf file Nov 5, 2020
To-om added a commit that referenced this issue Nov 13, 2020
@garanews
Copy link
Contributor

Issue is still present on 4.0.1-1 (tried on redhat and on docker)
as @confusedsecuritydudes said, if configure one MISP instance in thehive application.conf with this value
purpose = ExportOnly
with result that is not managed at all.

To reproduce issue

  1. set this in misp instance of application.conf :
    image

  2. go in the hive create case :
    image

  3. use export to send case to misp:
    image

  4. in misp event is created:
    image

  5. but in the hive alert from this event appears:
    image

It is all ok if ExportOnly value doesn't exist... the expected behavior with this value set is to do not create alert from that misp instance

@garanews garanews reopened this Nov 17, 2020
@OlivierGTelia
Copy link

I have the same problem, I am on Hive 4.1.2.
This only happens when a case is exported from hive -> MISP, an alert is created aswell.
Other cases create directly in MISP Manually or through other systems do not have this problem and dont create a hive alert.

@ch0wm3in
Copy link

ch0wm3in commented Aug 4, 2021

Still a issue on 4.1.6-1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug TheHive4 TheHive4 related issues
Projects
None yet
Development

No branches or pull requests

6 participants