Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] File observables with special character in name can not be downloaded #1842

Closed
KaanSK opened this issue Mar 16, 2021 · 1 comment
Closed
Assignees
Labels
bug TheHive4 TheHive4 related issues
Milestone

Comments

@KaanSK
Copy link
Contributor

KaanSK commented Mar 16, 2021

Work Environment

Question Answer
OS version (server) Ubuntu docker base image
OS version (client) All ...
TheHive version / git hash 4.0.5
Package Type DEB
Browser type & version All

Problem Description

File observables with special characters in filenames can not be downloaded. "Invalid filename" error is shown. File can be found in server filesystem.

Steps to Reproduce

  1. Create a file observable with example name: "Re: Re: malicious mail.eml"
  2. Try to download zipped file from TheHive UI
  3. Observe the error

Possible Solutions

  1. Filenaming logic (mapping filename to file) may be investigated
  2. Validations could be added on frontend and backend
  3. Special chars and whitespace could be stripped
@KaanSK KaanSK added TheHive4 TheHive4 related issues bug labels Mar 16, 2021
@nadouani nadouani added this to the 4.1.0 milestone Mar 17, 2021
@nadouani nadouani removed their assignment Mar 17, 2021
@To-om
Copy link
Contributor

To-om commented Mar 18, 2021

Some characters are prohibited

@To-om To-om closed this as completed Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug TheHive4 TheHive4 related issues
Projects
None yet
Development

No branches or pull requests

3 participants