Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] A security issue? #2008

Closed
o101010 opened this issue Apr 28, 2021 · 1 comment
Closed

[Question] A security issue? #2008

o101010 opened this issue Apr 28, 2021 · 1 comment
Assignees
Labels
bug TheHive4 TheHive4 related issues
Milestone

Comments

@o101010
Copy link

o101010 commented Apr 28, 2021

Request Type

Question

Work Environment

Question Answer
OS version (server) All
OS version (client) All
Virtualized Env. True / False
Dedicated RAM XX GB
vCPU 4 / 8 / 16 / 32
TheHive version / git hash 4.x, hash of the commit
Package Type RPM, DEB, Docker, Binary, From source
Database Cassandra / BerlkelyDB
Index type Lucene / Elasticsearch
Attachments storage Local, NFS, S3, HDFS
Browser type & version If applicable

Question

Hi.
Thank you for your amazing job on cortex and thehive. I'm exited by the next relase of cortex4, when i seen work on thehive4.

During my work on Thehive4 (and cortex3), I imagine a way to pass from one organization to another. In my opinion, it's a security issue that impact the confidentiality (an integrity).

Steps are pretty simple:

  1. Log as orgAdmin
  2. Create a new user that is already in another organization
  3. Reset his password (or create an API key)
  4. Log off yourself and login with this new account
  5. You have access to the two organizations.

It's due to the fact that TheHive autolink login user through multiple organizations.
A way to mitigate this issue is to separate local passwords* on differents organization. For delagated autentication flow (ad, oauth2, ...), this is not a problem because password can't be reset by TheHive. But local authenticate flows have priority by default.

@To-om
Copy link
Contributor

To-om commented Apr 30, 2021

You're right. But having a different password for each organisation is not desirable (and currently not feasible in TheHive).
I think the reset password should be avaiable only if the org-admin has the "manageUser" permission on all organisations of the targeted user. If this org-admin doesn't exist on the platform, the user must ask the super admin. This constaint could be ennoying but this is the only solution I see to mitigate the security risk.

@To-om To-om self-assigned this Apr 30, 2021
@To-om To-om added this to the 4.1.5 milestone Apr 30, 2021
@To-om To-om added bug TheHive4 TheHive4 related issues and removed question labels May 10, 2021
@To-om To-om closed this as completed May 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug TheHive4 TheHive4 related issues
Projects
None yet
Development

No branches or pull requests

2 participants