Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assign a default role to new users and remove the ability to assign empty roles #60

Closed
saadkadhi opened this issue Dec 13, 2016 · 1 comment
Assignees
Labels
Milestone

Comments

@saadkadhi
Copy link
Contributor

Request Type

Feature Request

Problem Description

When an administrator creates a new user, no default role is assigned by default. Hence, if they click on Add User, the new user will have no assigned role. This is not desirable and might create confusion.

For instance, we proceed with the creation of a new user whose login name is sabine:
th-2 9 1-usermgmt-1

Then we click on Add User:
th-2 9 1-usermgmt-2

Suggested Enhancement

Assign by default a normal analyst role to a new user (read and write). Also, make sure that an administrator cannot create an account without assigning a role. Empty roles have no use in my opinion. If we'd like to keep a user out, we just lock the account.

Complementary Information

Please note that users with empty roles are still able to log in. And while they can't see the list of cases nor the flow, they can still click on + New and fill the case creation form only to obtain an error at the end when they click on + Create case. They also get a slew of exceptions:
screen shot 2016-12-13 at 09 36 40

@saadkadhi
Copy link
Contributor Author

I can't reproduce the empty role list upon creating a user as shown in the screenshots I've added to the issue. I see now that the role field shows read by default, on Safari 10. TheHive instance is a 2.9.1.

So we need to make sure that there is no edge case where the default role is empty. I'd also suggest we consider changing the default role to read and write as more often than not, administrators will create regular analyst accounts.

@nadouani nadouani added this to the 2.9.2 milestone Dec 13, 2016
nadouani added a commit that referenced this issue Jan 2, 2017
@nadouani nadouani closed this as completed Jan 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants