Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AddTagToArtifact action to responders #717

Merged
merged 3 commits into from
Sep 19, 2018
Merged

Add AddTagToArtifact action to responders #717

merged 3 commits into from
Sep 19, 2018

Conversation

srilumpa
Copy link

@srilumpa srilumpa commented Sep 7, 2018

Here is a pull request to include a new action to TheHive responders which is tagging an artifact on which a responder was ran on. I have tested it by running on an artifact some dummy responder doing nothing and every seems to work.

Please note that I haven't tested the behavior when the action is ran against something that is not an artifact. For now, it is the responders which should add the action AddTagToArtifact only if the datatype thehive:case_artifact.

I hope this will fit your expectations.

@nadouani
Copy link
Contributor

Hello @srilumpa could you please fix the merging conflict on your PR? so we can merge it on 3.1.0?

@srilumpa
Copy link
Author

I Was working on it, it should be ok now.

Thanks a lot :)

@nadouani nadouani added this to the 3.1.0 milestone Sep 19, 2018
@To-om To-om merged commit 326e20e into TheHive-Project:develop Sep 19, 2018
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants