Sa 3139 replace iwr with sdk

[kmaranionjc]

Issues

• SA-3139 - SA-3139-Replace-Get-JCResults with SDK in Get-JCSystemApp

What does this solve?

Replace IWR with Get-JcSdkSystemInsight (SDK). Fixes output difference with system insights table and module output

Is there anything particularly tricky?

n/a

How should this be tested?

Run each of these commands and validate the results:

Get-JcSystemApp #Test with and without $Parallel

#SoftwareName

Get-JcSystemApp -softwareName “Microsoft Edge” 
Get-JcSystemApp -softwareName “Chess”  
Get-JcSystemApp -softwareName “firefox” 

#SoftwareName and OS

Get-JcSystemApp -softwareName “firefox” -systemOs “Linux” 
Get-JcSystemApp -softwareName “Chess” -systemOs “MacOs” 
Get-JcSystemApp -softwareName “Microsoft Edge” -systemOs “Windows” 

#SoftwareName and Id

Get-JcSystemApp -softwareName “Microsoft Edge” -systemId “Id”    #Windows 
Get-JcSystemApp -softwareName “firefox” -systemId “Id”  #Linux 
Get-JcSystemApp -softwareName “Chess” -systemId “Id” #Mac 

#SoftwareName and OS and version

Get-JcSystemApp -softwareName “Microsoft Edge” -systemOs “Windows” - softwareVersion “”
Get-JcSystemApp -softwareName “firefox” -systemOs “Linux” - softwareVersion “”
Get-JcSystemApp -softwareName “Chess” -systemOs “MacOs” - softwareVersion “”

#SoftwareName and Id and version

Get-JcSystemApp -softwareName “Microsoft Edge” -systemId “Id” - softwareVersion “” #Windows
Get-JcSystemApp -softwareName “firefox” -systemId “Id” - softwareVersion “” #Linux
Get-JcSystemApp -softwareName “Chess” -systemId “Id” - softwareVersion “” #MacOs

Test with and without $Parallel
#SoftwareName and Search. Test with and without $Parallel

Get-JcSystemApp -softwareName “microsoft Edge” -search
Get-JcSystemApp -softwareName “chess” -search
Get-JcSystemApp -softwareName “Firefox” -search

#SoftwareName and Os and Search

Get-JcSystemApp -softwareName “firefox” -systemOs “Linux” -search
Get-JcSystemApp -softwareName “safari” -systemOs “MacOs” -search
Get-JcSystemApp -softwareName “microsoft edge” -systemOs “Windows” -search

#SoftwareName and Id and Search

Get-JcSystemApp -softwareName “Microsoft Edge” -systemId “Id”    -search #Windows
Get-JcSystemApp -softwareName “firefox” -systemId “Id”  -search #Linux
Get-JcSystemApp -softwareName “Chess” -systemId “Id” -search #Mac

Screenshots

[jworkmanjc]

Only change I have on the branch is the quick change to Get-JCSdk system to just return fewer fields

[gweinjc]

Looks good, I noticed some string manipulation that could possibly be reduced, but that's pretty nitpicky. Nice job!

[jworkmanjc]

And last but not least, let's commit to changing our softwareName parameter to just Name and softwareVersion to just Version

[jworkmanjc]

Thanks for the changes