Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.0.4, update distribute script #497

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions scripts/automation/Radius/Changelog.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,17 @@
## 1.0.4

Release Date: June 5, 2023

#### RELEASE NOTES

```
Addressed an issue on macOS with EmailSAN and EmailDN type cert deployments where assigning network SSIDs during certificate import.
```

#### Bug Fixes:

- In previous versions, deploying either an EmailSAN or EmailDN type cert would throw an error while attempting to associate a network SSID to the newly imported certificate. The cert identifier in this case was updated to the SHA1 hash of the certificates instead of the common name (which was incorrectly identified in previous iterations of these example scripts).

## 1.0.3

Release Date: May 30, 2023
Expand Down
2 changes: 1 addition & 1 deletion scripts/automation/Radius/Config.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ $CertType = "UsernameCn"
# Do not modify below
################################################################################

$UserAgent_ModuleVersion = '1.0.3'
$UserAgent_ModuleVersion = '1.0.4'
$UserAgent_ModuleName = 'PasswordlessRadiusConfig'
#Build the UserAgent string
$UserAgent_ModuleName = "JumpCloud_$($UserAgent_ModuleName).PowerShellModule"
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,6 @@ foreach ($user in $userArray) {
$CommandBody = @{
Name = "RadiusCert-Install:$($user.userName):MacOSX"
Command = @"
set -e
unzip -o /tmp/$($user.userName)-client-signed.zip -d /tmp
chmod 755 /tmp/$($user.userName)-client-signed.pfx
currentUser=`$(/usr/bin/stat -f%Su /dev/console)
Expand Down Expand Up @@ -148,6 +147,8 @@ if [[ `$currentUser == $($user.userName) ]]; then
for (( i=0; i<`$len; i++ )); do
if [[ `$currentCertSN == `${arraySN[`$i]} ]]; then
echo "Found Cert: SN: `${arraySN[`$i]} SHA: `${arraySHA[`$i]}"
installedCertSN=`${arraySN[`$i]}
installedCertSHA=`${arraySHA[`$i]}
# if cert is installed, no need to update
import=false
else
Expand All @@ -165,22 +166,42 @@ if [[ `$currentUser == $($user.userName) ]]; then
/bin/launchctl asuser "`$currentUserUID" sudo -iu "`$currentUser" /usr/bin/security import /tmp/$($user.userName)-client-signed.pfx -k /Users/$($user.userName)/Library/Keychains/login.keychain -P $JCUSERCERTPASS -T "/System/Library/SystemConfiguration/EAPOLController.bundle/Contents/Resources/eapolclient"
if [[ `$? -eq 0 ]]; then
echo "Import Success"
# get the SHA hash of the newly imported cert
installedCertSN=`$(/bin/launchctl asuser "`$currentUserUID" sudo -iu "`$currentUser" /usr/bin/security find-certificate -$($macCertSearch) "$($certIdentifier)" -Z /Users/$($user.userName)/Library/Keychains/login.keychain | grep snbr | awk '{print `$1}' | sed 's/"snbr"<blob>=0x//g')
if [[ `$installedCertSN == `$currentCertSN ]]; then
installedCertSHA=`$(/bin/launchctl asuser "`$currentUserUID" sudo -iu "`$currentUser" /usr/bin/security find-certificate -$($macCertSearch) "$($certIdentifier)" -Z /Users/$($user.userName)/Library/Keychains/login.keychain | grep SHA-1 | awk '{print `$3}')
fi

else
echo "import failed"
exit 4
fi
# set ssid info; this prevents multiple password prompts
for i in `${networkSsid[@]}; do
/bin/launchctl asuser "`$currentUserUID" sudo -iu "`$currentUser" /usr/bin/security set-identity-preference -s "com.apple.network.eap.user.identity.wlan.ssid.`$i" -$($macCertSearch) "$($certIdentifier)"
else
echo "cert already imported"
fi

# check if the cert secruity preference is set:
for i in `${networkSsid[@]}; do
echo "begin sertting network SSID: `$i security certificate"
if /bin/launchctl asuser "`$currentUserUID" sudo -iu "`$currentUser" /usr/bin/security get-identity-preference -s "com.apple.network.eap.user.identity.wlan.ssid.`$i" -Z "`$installedCertSHA"; then
echo "it was already set"
else
echo "certificate not linked from SSID: `$i to certSN: `$currentCertSN, setting now"
/bin/launchctl asuser "`$currentUserUID" sudo -iu "`$currentUser" /usr/bin/security set-identity-preference -s "com.apple.network.eap.user.identity.wlan.ssid.`$i" -Z "`$installedCertSHA"
if [[ `$? -eq 0 ]]; then
echo "SSID: `$i and certificate linked"
echo "SSID: `$i and certificate linked"
else
echo "Could not associate SSID: `$i and certifiacte"
fi
done
else
echo "cert already imported"
fi
fi
done


# print results
echo "################## Cert Install Results ##################"
echo "Installed Cert SN: `$installedCertSN"
echo "Installed Cert SHA1: `$installedCertSHA"
echo "##########################################################"

# Finally clean up files
if [[ -f "/tmp/$($user.userName)-client-signed.zip" ]]; then
Expand Down