Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

local user fix for cert CN identification #502

Merged
merged 3 commits into from
Jul 20, 2023

Conversation

jworkmanjc
Copy link
Contributor

@jworkmanjc jworkmanjc commented Jun 29, 2023

Issues

  • SA-3225 - Local Username Certificate CN Fix

What does this solve?

Previously when generating certificates with users who also have a systemUsername (local username account field set). The resulting certificates were generated with a users 'systemUsername'. Radius authentication only matches a user's username and user's with these certificates would never be allowed to access a radius backed network.

This change tracks a user's localUsername and username (if both exist). Certs are generated with the users username but installed to the localUsername directory.

Is there anything particularly tricky?

How should this be tested?

  • Associate a user who has a systemUsername (local username account field set) to a radius access group
  • Generate a radius user certificate for this user
  • distribute the radius certificate to the user's macOS and windows system
  • the certificate should install
  • the certificate should allow a user to access a radius backed network even though their localUsername is different from the CA in the resulting certificate.

Screenshots

@jworkmanjc
Copy link
Contributor Author

Tested both Windows/ macOS deployments.

Both users have a local username, the installation scripts correctly install the certificate, certificate auth to radius network will not throw handshake failure.

Copy link
Contributor

@kmaranionjc kmaranionjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests looks good

Copy link
Contributor

@gweinjc gweinjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Certs were installed correctly for the localUser and was able to authenticate using their username

@jworkmanjc jworkmanjc merged commit 5898cd0 into master Jul 20, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants