JumpCloud PowerShell Module v2.7.0 #505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….com/TheJumpCloud/support into SA-3176_ImportRegFilesRegistryPolicy
…JumpCloud/support into SA-3176_ImportRegFilesRegistryPolicy
…tryPolicy SA-3176: New/Set-JCPolicy Import Reg Files
jworkmanjc
reviewed
Aug 1, 2023
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
| end { | ||
| if ($totalCountHeader) { | ||
| if ($parallel -and $totalCountHeader) { |
There was a problem hiding this comment.
I can confirm this resolves the issue for my older version of PWSH
jworkmanjc
approved these changes
Aug 1, 2023
There was a problem hiding this comment.
Import REG Tests:
Import Test With Just One registry .reg Item ✅
Import Test with Multiple registry .reg items ✅
Set Test without -RegistryOverwrite param ✅ policy is appended
Set Test with -RegistryOverwrite param ✅ policy is overwritten
Setting a policy where a policy has the same name as another policy does throw an error as expected.
Finally I can confirm that these changes do address the bug in the older version of PWSH:
kmaranionjc
reviewed
Aug 1, 2023
kmaranionjc
approved these changes
Aug 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues
What does this solve?
This feature will allow admins to upload
.regfiles into new or existingWindows - Advanced: Custom Registry Keys PolicyJumpCloud Policies to deploy to their Windows machines.This also resolves a bug where
Get-JCResultswas not adding all indexes of an object to the parent array as expected and was instead adding a single instance to the array containing all objects which was causing issues with counts and object manipulationIs there anything particularly tricky?
Currently,
Windows - Advanced: Custom Registry Keys Policyonly accepts registry keys that belong in the HKEY_LOCAL_MACHINE (HKLM) hive. If a .reg file is attempted to be uploaded that contains a non-HKLM key, it will not be valid.How should this be tested?
Registry File Work
Download the sample .reg file and unzip
i. SampleRegFile.reg.zip
Run the following function:
ii.
New-JCPolicy -TemplateName windows_Advanced:_Custom_Registry_Keys -Name "Test - Registry File Upload" -registryFile "/path/to/SampleRegFile.reg"Validate that the "Test - Registry File Upload" Policy was successfully created and contains the expected registry values
Run the following function:
iv.
Set-JCPolicy -PolicyName "Test - Registry File Upload" -registryFile "/path/to/SampleRegFile.reg"Validate that the "Test - Registry File Upload" Policy now has 10 values instead of the original 5
Run the following function to replace the existing values of the policy with just the values from the SampleRegFile:
iv.
Set-JCPolicy -PolicyName "Test - Registry File Upload" -registryFile "/path/to/SampleRegFile.reg" -registryOverwriteValidate that the "Test - Registry File Upload" Policy now has the 5 values from the file
Get-JCResults Work
5.1.19041.2673