Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.0.6 multi ssid and non-exportable macos certs #516

Merged
merged 2 commits into from
Sep 27, 2023

Conversation

jworkmanjc
Copy link
Contributor

@jworkmanjc jworkmanjc commented Sep 25, 2023

Issues

  • SA-3558 - Multiple SSIDs with spaces

What does this solve?

In previous versions of the radius example scripts, multiple SSIDs could be specified as long as those SSIDs did not have a space in the name. Some SSID set like "network_5G network_2.5G" would have been valid in a previous release whereas "network 5G network 2.5G" would not. In this release, space is no longer a delimiter to split network names, instead, the semicolon ";" is used to split network names. In this release setting the $NETWORKSSID variable to "network 5G;network 2.5G" would assign a macOS user's wifi certificate to both networks network 5G and network 2.5G

In addition this release changes the import certificate macOS security commands slightly by adding the -x flag which prevents the certificates from being exported from the keychain after installation.

Is there anything particularly tricky?

NA

How should this be tested?

In the radius config.ps1 file, change the $NETWORKSSID variable to a string with several network names one of which should have a space in the name.

Generate and distribute a set of certs to a test user on a VM, when the certificate is distributed and installed on the user's device, the certificate should be set to automatically apply when connected to each network specified in the $NETWORKSSID variable.

Furthermore the installed certificate should no longer be exportable once it's in the user's keychain

Screenshots

In this screenshot both networks TP-Link_3832 and Some network with a space were set to use the installed certificate for authentication after the certificate was installed:

Screenshot 2023-09-25 at 1 43 43 PM

After the certificate was installed, it can no longer be exported by right-clicking the private key and selecting export. The following error should be displayed when a user attempts to export this installed certificate.

Screen Shot 2023-09-12 at 10 50 38 AM 2

Copy link
Contributor

@gweinjc gweinjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works in my test org, nice job

Copy link
Contributor

@kmaranionjc kmaranionjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great with my test. Awesome job!

@jworkmanjc jworkmanjc merged commit 8d34119 into master Sep 27, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants