-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added fix to string value error #544
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've at least validated this locally. Can you add a test to this release to configure a windows update policy + set the specific config field where we encountered this issue. Test should do this:
Create a new policy
Set the specific field where we encountered this issue in the first place
test that the setting of that field | Should -Not Throw
Validate that the field is set to the desired value
ie.
($policy.Values | where {$_.configFieldID -eq 1234 }).value | should -be "theExpectedValueSetAbove"
I'd want to see this as part of the release before I approve.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally and can see that this is working for the windows update policy. Thanks for the work here and looks like you have the functionality covered in your new test. ✅
Issues
What does this solve?
Fixes issue with policy value converting a string to an integer error
Is there anything particularly tricky?
n/a
How should this be tested?
Screenshots