Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added fix to string value error #544

Merged
merged 7 commits into from
Nov 20, 2023
Merged

Conversation

kmaranionjc
Copy link
Contributor

@kmaranionjc kmaranionjc commented Nov 15, 2023

Issues

  • SA-3679 - SA-3679-PolicytoPatch-Copy

What does this solve?

Fixes issue with policy value converting a string to an integer error

Is there anything particularly tricky?

n/a

How should this be tested?

  1. Run this with the current module: Set-JCPolicy -id POLICYID -AUTO_INSTALL_SCHEDULE ScheduledInstallFourthWeek
  • This should output an error
  1. Run the same code with this module, validate that the issue is fixed

Screenshots

@kmaranionjc kmaranionjc requested a review from a team as a code owner November 15, 2023 21:16
@jworkmanjc jworkmanjc added PowerShell Module Release for JumpCloud PowerShell Module patch labels Nov 15, 2023
Copy link
Contributor

@jworkmanjc jworkmanjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've at least validated this locally. Can you add a test to this release to configure a windows update policy + set the specific config field where we encountered this issue. Test should do this:

Create a new policy
Set the specific field where we encountered this issue in the first place
test that the setting of that field | Should -Not Throw
Validate that the field is set to the desired value
ie.
($policy.Values | where {$_.configFieldID -eq 1234 }).value | should -be "theExpectedValueSetAbove"

I'd want to see this as part of the release before I approve.

Copy link
Contributor

@jworkmanjc jworkmanjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and can see that this is working for the windows update policy. Thanks for the work here and looks like you have the functionality covered in your new test. ✅

@kmaranionjc kmaranionjc merged commit fb19481 into master Nov 20, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch PowerShell Module Release for JumpCloud PowerShell Module
Development

Successfully merging this pull request may close these issues.

3 participants