Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sa 3721 system username return property get jc user #552

Merged
merged 3 commits into from
Jan 9, 2024
Merged

Sa 3721 system username return property get jc user #552

merged 3 commits into from
Jan 9, 2024

Conversation

jworkmanjc
Copy link
Contributor

@jworkmanjc jworkmanjc commented Jan 2, 2024 •
edited by jira bot
Loading

Issues

  • SA-3121 - Add systemUsername to Get-JCUser returnProperties

What does this solve?

Adds the systemUsername field as an available property to return when performing a search

Is there anything particularly tricky?

NA

How should this be tested?

Given a user with a specified systemUsername. Running the following command should return that user's specified systemUsername.

Screenshots

Screenshot 2024-01-02 at 9 24 31 AM

jworkmanjc and others added 2 commits January 2, 2024 09:14
@jworkmanjc
Update Get-JCUser.ps1
c3009b3 
add system user to return properties of Get-JCUser
@jworkmanjc
Update Docs, PSD1, HelpFiles
ddad6f3
@jworkmanjc jworkmanjc requested a review from a team as a code owner January 2, 2024 16:25
@jworkmanjc jworkmanjc added PowerShell Module Release for JumpCloud PowerShell Module patch labels Jan 2, 2024
gweinjc
gweinjc approved these changes Jan 2, 2024
View reviewed changes
Copy link
Contributor

@gweinjc gweinjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested good for me

@kmaranionjc kmaranionjc self-requested a review January 9, 2024 16:23
@jworkmanjc jworkmanjc merged commit 6446941 into master Jan 9, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gweinjc gweinjc gweinjc approved these changes

@kmaranionjc kmaranionjc kmaranionjc approved these changes

Assignees
No one assigned
Labels
patch PowerShell Module Release for JumpCloud PowerShell Module
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jworkmanjc @gweinjc @kmaranionjc