-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CUT-4228: Get-JCAdmin Function #593
Conversation
…onTests CUT-4128: Missing Documentation Pester Tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is really great, two items I believe we should change but otherwise perfect execution here.
There's no way to get around the filtering, that's okay.
Let me know what you think about those two comments on the params?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Tests worked on my end and code looks good.
Issues
What does this solve?
This new function allows for administrators to query the administrators in their organization. MTP/MSP tenants will have the ability to query all of their organizations or individually.
Is there anything particularly tricky?
Since the endpoint used to query admins does not have a
searchFilter
option, we had to manually create a filter using a foreach loop on the inputted params.The
$filterScript
is then used in aWhere-Object -FilterScript $FilterScript
to perform the actual filteringHow should this be tested?
Non-MTP/MSP Tenant
MTP/MSP Tenants