-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NB-12742: Added PWM MacOS architecture detection, redirection to ARM download #600
base: master
Are you sure you want to change the base?
NB-12742: Added PWM MacOS architecture detection, redirection to ARM download #600
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@oalobajijc feel free to merge, I'm sorry this went so long without us looking at it. |
@jworkmanjc No worries! Thanks for the approval. I won't be merging this now, as we discovered & are investigating an issue related to ARM builds unrelated to this script. I'll merge when it's fixed |
Feel free to just leave it open, doesn't matter to me :) |
Issues
Dependencies
What does this solve?
It adds the ability for the script to download arm64 PWM builds directly instead of Intel based builds.
Is there anything particularly tricky?
No, just to note that when the dependency PR gets merged, we will be able to successfully test it on the prod cdn. (using the prod link)
This is how the prod link for MacOS ARM builds will look like:
https://cdn.pwm.jumpcloud.com/DA/release/arm64/JumpCloud-Password-Manager-latest.dmg
Staging link (just for reference):
https://cdn.pwm.stg01.jumpcloud.com/DA/staging/release/arm64/JumpCloud-Password-Manager-Staging-latest.dmg
How should this be tested?
Testing is done only on MacOS, no need for any other OS.
***NOTE: If you're to test on staging (before the release is merged & deployed) please check the end of the
How should this be tested?
block right after step 2.arm64
architecture (you can rununame -m
in your terminal, output should bearm64
).sh
file containing the following:~/Applications/
JumpCloud Password Manager
if you're using the prod link,JC Password Manager Staging
if you're using stagingApple Silicon
as the app type (Screenshot attached)If you're testing on staging, you should modify the following in the
.sh
file:Screenshots