Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import/Update CSV attribute bug fix #614

Merged
merged 5 commits into from
Oct 16, 2024

Conversation

kmaranionjc
Copy link
Contributor

@kmaranionjc kmaranionjc commented Oct 15, 2024

Issues

  • CUT-4320 - CUT-4320-CustomAttribute-Bug-Import-Update-User-CSV

What does this solve?

Fixes an issue when some Attribute fields are not null or empty which results to user not being updated

Is there anything particularly tricky?

n/a

How should this be tested?

  1. Import new users with multiple attributes where atleast one attribute name and value is empty. Check CSV below for example
    NewUserCSV.csv
  2. Validate that all users are created even with some Attributes that are empty
  3. Run Update-JCUsersFromCSV where one of the Attribute fields on your CSV to be empty. CSV below for example
    UpdateUser.csv
  4. Validate the users custom attributes are updated

Screenshots

Attribute 2 is empty on this Import. The new bug fix reorganized the row to keep the numerical formality which renamed Attribute3 to Attribute2,
image

@kmaranionjc kmaranionjc added PowerShell Module Release for JumpCloud PowerShell Module patch labels Oct 15, 2024
@kmaranionjc kmaranionjc self-assigned this Oct 15, 2024
@kmaranionjc kmaranionjc requested a review from a team as a code owner October 15, 2024 21:46
Copy link
Contributor

@jworkmanjc jworkmanjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay this is great work, thanks for the detailed tests and testing AC, I can see the users updating their attributes using the CSV files attached.

Copy link
Contributor

@gweinjc gweinjc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, nice job!

@kmaranionjc kmaranionjc merged commit 266ee93 into master Oct 16, 2024
10 checks passed
@kmaranionjc kmaranionjc deployed to PublishToPSGallery October 16, 2024 21:24 — with GitHub Actions Active
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch PowerShell Module Release for JumpCloud PowerShell Module
Development

Successfully merging this pull request may close these issues.

3 participants