-
-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use ClutterActor's expand/align properties #22
Conversation
BoxLayout meta child (expand/align) properties have long been depracated and recently fully removed in gnome shell 3.37.2 (!1274), in favor of ClutterActor's ones. Embrace the change to provide compatibility with upcoming gnome shell 3.38 release
With this, and updating the metadata.json file, it also works with Gnome Shell 40. |
Added the patch by squall77it TheKevJames#22 which adds compatibility with Gnome Shell 3.38. Also added "40" in metadata.json.
@squall77it @rastersoft I successfully replaced this extension.js and modified metadata.json to make it work with Gnome 42. Is there maybe a possibility this can officially be forked and published on the official Gnome extensions site? Because a lot of people are not that technical. |
I have to warn that it gives problem on Gnome 42 (at least on Ubuntu 22.04). I have had system crash and according my syslog it was after errors of this extension in the same log file.
|
Sorry for my incredibly long delay on noticing this one. I don't currently have a gnome box to test this on, but happy to handle publishing and all that. Am I correct in assuming this PR would change the supported shell versions to 38, 40, and 42? /cc @joenepraat @squall77it If that's the case, happy to merge & publish accordingly. |
@TheKevJames I don't think this should be used on Gnome 42. It gave those errors I pasted above, plus I remember that the settings dialog didn't work either. |
Gotcha, thanks for confirming. Alright, I'll get this up targeting 38&40, and then we'll see about getting v42 supported separately. |
BoxLayout meta child (expand/align) properties have long been depracated and recently fully removed in gnome shell 3.37.2 (!1274), in favor of ClutterActor's ones.
Embrace the change to provide compatibility with upcoming gnome shell 3.38 release