Add dummy targets as dependencies when tools are unavailable #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch! Also thanks for improving the diagnostics. I'll update the CI here as well to test buildability with missing dependencies. |
|
I've released the fix in version 1.5.2. Thanks again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When external tool dependencies are not installed, the dummy targets are not appended to their respective target list. Consequently, the CMake generate step fails when adding dependencies with empty/uninitialized variables.
Also modified the print messages slightly to be more consistent with CPM's printouts.
Tested by setting the tool conditional checks to 'false' manually and also by using a Windows GitHub Action in the "ModernCppStarter" repository without deliberately installing Clang or
cmake-format.