Wildcard support #18
Merged
Wildcard support #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
NonSwag
commented
Aug 9, 2024
•
NonSwag
commented
- paper
- command permission
- command hide
- command reset
- command unregister
- velocity
- command permission
- command hide
- command reset
- command unregister
Adjusted the indentation for the getSuggestions method to improve readability. This change does not alter the functionality but ensures consistent code formatting.
Utilize `findCommands` method to streamline command lookup and matching. This enhances maintainability and ensure consistent command filtering across multiple operations like hide, register, reveal, and unregister. Introduces regex pattern matching to support more flexible command searches.
Refactored `findCommands` methods to be static for better accessibility and potential use without needing an instance of `PaperCommandRegistry`. This change will also help in simplifying unit tests related to command finding functionality.
Replace direct permission and reset operations with bulk command handling using 'findCommands'. This enhancement ensures that all relevant commands are consistently updated or reset, streamlining the internal logic and improving maintainability.
Closed
Introduce the CommandFinder interface to streamline command search functionality. Added implementations for both Paper and Velocity platforms. Also updated Commander and related plugins to integrate the CommandFinder feature.
Refactor PaperCommandRegistry and PaperPermissionOverride to use the plugin's commandFinder utility for command searching. This enhances code maintainability by centralizing command lookup logic and removes redundant static methods.
Update `ProxyCommandRegistry` and `ProxyPermissionOverride` to improve command lookup and manipulation. Ensure hidden, unregistered, and overridden commands are accurately processed by integrating enhanced command finding logic.
Bump version from 4.0.0 to 4.1.0 in CommanderPlugin.java and build.gradle.kts. This reflects the latest changes and improvements in the project.
This reverts commit 64e44cd.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.