-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
javascript/organizing_your_javascript_code/factory_functions_and_module_pattern.md - revamps the lesson #26339
javascript/organizing_your_javascript_code/factory_functions_and_module_pattern.md - revamps the lesson #26339
Conversation
javascript/organizing_your_javascript_code/factory_functions_and_module_pattern.md
Outdated
Show resolved
Hide resolved
javascript/organizing_your_javascript_code/factory_functions_and_module_pattern.md
Outdated
Show resolved
Hide resolved
javascript/organizing_your_javascript_code/factory_functions_and_module_pattern.md
Outdated
Show resolved
Hide resolved
javascript/organizing_your_javascript_code/factory_functions_and_module_pattern.md
Outdated
Show resolved
Hide resolved
javascript/organizing_your_javascript_code/factory_functions_and_module_pattern.md
Outdated
Show resolved
Hide resolved
javascript/organizing_your_javascript_code/factory_functions_and_module_pattern.md
Outdated
Show resolved
Hide resolved
javascript/organizing_your_javascript_code/factory_functions_and_module_pattern.md
Outdated
Show resolved
Hide resolved
javascript/organizing_your_javascript_code/factory_functions_and_module_pattern.md
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work on this so far 🚀
I was only able to partially go through it right now but I wanted to get started on it while I had a chance. Feel free to make (or discuss) the changes I've suggested so far now if you'd like to, but if you'd rather wait until I finish up (should be able to in the next few days) that is fine too.
javascript/organizing_your_javascript_code/factory_functions_and_module_pattern.md
Outdated
Show resolved
Hide resolved
javascript/organizing_your_javascript_code/factory_functions_and_module_pattern.md
Show resolved
Hide resolved
javascript/organizing_your_javascript_code/factory_functions_and_module_pattern.md
Outdated
Show resolved
Hide resolved
javascript/organizing_your_javascript_code/factory_functions_and_module_pattern.md
Outdated
Show resolved
Hide resolved
javascript/organizing_your_javascript_code/factory_functions_and_module_pattern.md
Outdated
Show resolved
Hide resolved
@wise-king-sullyman I fixed all the reviews for now, will check on it soon. |
javascript/organizing_your_javascript_code/factory_functions_and_module_pattern.md
Outdated
Show resolved
Hide resolved
@wise-king-sullyman, I think this should wrap it up, if you're done with the reviews? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep looks great, thanks for all your work on this!
Because
Addresses the problems with the general disorganization of the lesson as mentioned in #26225 and revamps the included resources.
This PR
Issue
Closes #26225
Additional Information
N/A
Pull Request Requirements
location of change: brief description of change
format, e.g.Intro to HTML and CSS lesson: Fix link text
Because
section summarizes the reason for this PRThis PR
section has a bullet point list describing the changes in this PRIssue
section