Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin Dashboard: Remove step on color palettes #29160

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

MaoShizhong
Copy link
Contributor

@MaoShizhong MaoShizhong commented Dec 7, 2024

Because

As per the comments below, removed the color palettes step entirely as not vital for the project.

The current link text for the Tailwind colour palettes page just says "Tailwind", which can be made more descriptive since it links to a specific page within that site. Over the months there have also been a few questions implying people think they need to use Tailwind for this, and I suspect omitting "Tailwind" from the link text may get the point across that it's just some colour palette suggestions?

This PR

  • Removes color palette step

Issue

N/A

Additional Information

Pull Request Requirements

  • I have thoroughly read and understand The Odin Project curriculum contributing guide
  • The title of this PR follows the location of change: brief description of change format, e.g. Intro to HTML and CSS lesson: Fix link text
  • The Because section summarizes the reason for this PR
  • The This PR section has a bullet point list describing the changes in this PR
  • If this PR addresses an open issue, it is linked in the Issue section
  • If any lesson files are included in this PR, they have been previewed with the Markdown preview tool to ensure it is formatted correctly
  • If any lesson files are included in this PR, they follow the Layout Style Guide

@github-actions github-actions bot added the Content: Intermediate HTML/CSS Involves the Intermediate HTML/CSS course label Dec 7, 2024
@MaoShizhong
Copy link
Contributor Author

MaoShizhong commented Dec 7, 2024

On second thought, do we think we actually need to link to anything in this step or perhaps even include this step at all? I wonder if we can just omit this step entirely and if people want to search up colour palettes then that's just a google search away, and it might pull focus away from wasting time on design elements/colour theory etc. (which has been an occasional question in the community, not necessarily due to this project though)?

@wise-king-sullyman wise-king-sullyman requested review from a team and ManonLef and removed request for a team December 10, 2024 01:56
@KevinMulhern
Copy link
Member

Those sound like solid reasons for removing to me @MaoShizhong!

@MaoShizhong MaoShizhong changed the title Admin Dashboard: Rephrase color palettes step and link text Admin Dashboard: Remove step on color palettes Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content: Intermediate HTML/CSS Involves the Intermediate HTML/CSS course
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants