Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.md #1

Merged
merged 2 commits into from
Jan 17, 2023
Merged

Update index.md #1

merged 2 commits into from
Jan 17, 2023

Conversation

tajkirkpatrick
Copy link

First draft rewrite.

Still missing a few instructions such as, node version disclaimer, polyfill disclaimer, setting up the astro.config.mjs in server mode (and accompanying adapter), rewording the callback URL explanation, and explaining the authOptions object that needs to be created by the end user as well as what actions to take when changing the prefix from the default "/api/auth" prefix.

NOTE:

  • It's a good idea to open an issue first to discuss potential changes.
  • Please make sure that you are NOT opening a PR to fix a potential security vulnerability. Instead, please follow the Security guidelines to disclose the issue to us confidentially.

☕️ Reasoning

🧢 Checklist

  • Documentation
  • Tests
  • Ready to be merged

🎫 Affected issues

Please scout and link issues that might be solved by this PR.

Fixes: INSERT_ISSUE_LINK_HERE

📌 Resources

First draft rewrite. Still missing a few instructions such as, node version disclaimer, polyfill disclaimer, setting up the astro.config.mjs in server mode (and accompanying adapter), rewording the callback URL explanation, and explaining the authOptions object that needs to be created by the end user as well as what actions to take when changing the prefix from the default "/api/auth" prefix.
Copy link
Owner

@TheOtterlord TheOtterlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks awesome. Added a few minor notes for syntax highlighting & info card markup

docs/docs/reference/04-astro/index.md Outdated Show resolved Hide resolved
docs/docs/reference/04-astro/index.md Outdated Show resolved Hide resolved
docs/docs/reference/04-astro/index.md Outdated Show resolved Hide resolved
docs/docs/reference/04-astro/index.md Outdated Show resolved Hide resolved
docs/docs/reference/04-astro/index.md Outdated Show resolved Hide resolved
Co-authored-by: Reuben Tier <64310361+TheOtterlord@users.noreply.github.com>
@TheOtterlord TheOtterlord merged commit ecbc4e5 into TheOtterlord:main Jan 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants