-
-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated support for Ruby #326
Conversation
Merge latest origin changes
Awesome, i hope to see this on master soon! |
Hey @pranavrao145 @teddylear. Would love your thoughts and feedback on the above pull. Appreciate adding another language into the plugin is a big step and I am willing to offer support for any Ruby issues that arise. |
Thanks for testing. There's going to be a few of these gotchas. For each error, can you share the ruby code before the refactor, what you expected and what you got. I can turn that into a test case which we can forever test against. |
@olimorris Thanks for the contribution! Sorry it took a while to review, but this looks good to me so I'm down to merge. @otavioschwanck Thanks for testing this! If there are some errors please create a separate issue for each with code examples so that we can add test cases and resolve. |
Firstly, I want to say thank you to mcritchlow for the initial pull request.
This pull requests builds on that substantially and adds 106 and 119 support. I'm keen to support this moving forward (one of my passions is adding increased support for Ruby in Neovim) and feel it's best to just ship it and add 123 support later.
Edit: Now with full debug operations support
Edit: Now with 123 support for single variables (working on additing multiples)