Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated support for Ruby #326

Merged
merged 32 commits into from
Jun 30, 2022
Merged

Updated support for Ruby #326

merged 32 commits into from
Jun 30, 2022

Conversation

olimorris
Copy link
Contributor

@olimorris olimorris commented Jun 27, 2022

Firstly, I want to say thank you to mcritchlow for the initial pull request.

This pull requests builds on that substantially and adds 106 and 119 support. I'm keen to support this moving forward (one of my passions is adding increased support for Ruby in Neovim) and feel it's best to just ship it and add 123 support later.

Edit: Now with full debug operations support

Edit: Now with 123 support for single variables (working on additing multiples)

@otavioschwanck
Copy link

Awesome, i hope to see this on master soon!

@olimorris
Copy link
Contributor Author

Hey @pranavrao145 @teddylear. Would love your thoughts and feedback on the above pull. Appreciate adding another language into the plugin is a big step and I am willing to offer support for any Ruby issues that arise.

@otavioschwanck
Copy link

Extract function not working:
image

Tried to extract:

      filename = file[:filename]
      content_type = MIME::Types.type_for(file[:filename])[0].to_s

Extract function to a file is working (but dont add the parameters)

Extract variable throws an error

Extract variable inline throws an error

@olimorris
Copy link
Contributor Author

Thanks for testing. There's going to be a few of these gotchas.

For each error, can you share the ruby code before the refactor, what you expected and what you got. I can turn that into a test case which we can forever test against.

@teddylear
Copy link
Collaborator

@olimorris Thanks for the contribution! Sorry it took a while to review, but this looks good to me so I'm down to merge.

@otavioschwanck Thanks for testing this! If there are some errors please create a separate issue for each with code examples so that we can add test cases and resolve.

@teddylear teddylear merged commit 50cc6e4 into ThePrimeagen:master Jun 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants