Exclude error prone annotations from the build

The annotations are not required by Guice at runtime, see google/guice#1739
ThePumpingLemma · Jul 6, 2023 · f2f53e3 · f2f53e3
1 parent a81b4e6
commit f2f53e3
Show file tree

Hide file tree

Showing 5 changed files with 4 additions and 4 deletions.
diff --git a/build.gradle.kts b/build.gradle.kts
@@ -194,6 +194,10 @@ subprojects {
     resolutionStrategy.capabilitiesResolution.withCapability("com.google.guava:listenablefuture") {
       select("com.google.guava:guava:0")
     }
+
+    // Omit optional dependency from Guice + Guava.
+    // https://github.com/google/guice/pull/1739
+    exclude(group = "com.google.errorprone", module = "error_prone_annotations")
   }
 }
 

diff --git a/buildSrc/src/main/kotlin/Dependencies.kt b/buildSrc/src/main/kotlin/Dependencies.kt
@@ -25,7 +25,6 @@ object Dependencies {
   val dockerTransport = "com.github.docker-java:docker-java-transport:3.3.0"
   val dockerTransportHttpClient = "com.github.docker-java:docker-java-transport-httpclient5:3.3.0"
   val dokkaGradlePlugin = "org.jetbrains.dokka:dokka-gradle-plugin:1.6.10"
-  val errorproneAnnotations = "com.google.errorprone:error_prone_annotations:2.20.0"
   val findBugs = "com.google.code.findbugs:jsr305:3.0.2"
   val gax = "com.google.api:gax:2.5.0"
   val gcpCloudCore = "com.google.cloud:google-cloud-core:1.95.4"

diff --git a/misk-aws-dynamodb-testing/build.gradle.kts b/misk-aws-dynamodb-testing/build.gradle.kts
@@ -16,7 +16,6 @@ dependencies {
   api(Dependencies.tempestTestingInternal)
   api(project(":misk-aws-dynamodb"))
   api(project(":misk-inject"))
-  implementation(Dependencies.errorproneAnnotations)
   implementation(Dependencies.kotlinReflect)
   implementation(Dependencies.tempestTesting)
   implementation(Dependencies.tempestTestingDocker)

diff --git a/misk-aws2-dynamodb-testing/build.gradle.kts b/misk-aws2-dynamodb-testing/build.gradle.kts
@@ -18,7 +18,6 @@ dependencies {
   api(project(":misk-aws2-dynamodb"))
   api(project(":misk-inject"))
   api(project(":misk-testing"))
-  implementation(Dependencies.errorproneAnnotations)
   implementation(Dependencies.tempest2Testing)
   implementation(Dependencies.tempest2TestingDocker)
   implementation(Dependencies.tempest2TestingJvm)

diff --git a/misk-clustering/build.gradle.kts b/misk-clustering/build.gradle.kts
@@ -15,7 +15,6 @@ dependencies {
   api(Dependencies.wispConfig)
   api(Dependencies.wispLeaseTesting)
   api(project(":misk-inject"))
-  implementation(Dependencies.errorproneAnnotations)
   implementation(Dependencies.guice)
   implementation(Dependencies.kubernetesClient)
   implementation(Dependencies.kubernetesClientApi)