tf2 does not work for ExportModel #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Transformer blocks in the original Pegasus code use modules from contrib (which has been removed from tf2.0). As a result, the ExportModel functionality just breaks with tf2. Code blocks used `layer_norm` from contrib, which could be replaced with Keras layers. But the `contrib_training.HParams` in `pegasus/params/pegasus_params.py` does not have a replacement in tf2. This might be useful for the next person who tries to export the model :)
|
I have not. Sorry. Why would you replace it if it works? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @TheRockXu ,
Thanks for putting this together. Raising a PR because there was no way to create an issue on your repo.
I was trying to export the original checkpoints which Pegasus provides (wanted to replicate the results as closely as possible).
This might be useful for the next person who tries to export the model :)
The Transformer blocks in the original Pegasus code use modules from contrib (which has been removed from tf2.0).
As a result, the ExportModel functionality just breaks with tf2. ==> transformer_block
Code blocks used
layer_normfrom contrib, which could be replaced with Keras layers.But the
contrib_training.HParamsinpegasus/params/pegasus_params.pydoes not have a replacement in tf2 ==> params.If you ever find a workaround, do let me know.
Thanks!