[WIP] feat: add shared models and reusable hooks for table state management… #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pzmuda1
force-pushed
the
feat/data-grid-update
branch
from
f4629c6
to
4849a1d
Compare
… and request params preparation
pzmuda1
force-pushed
the
feat/data-grid-update
branch
from
4849a1d
to
de7a5b3
Compare
AdamKniec
reviewed
Mar 28, 2024
AdamKniec
reviewed
Mar 28, 2024
|
|
||
| useEffect(() => { | ||
| setParams(mapStateToRequestParams(pagination, sort, filters, globalFilter)); | ||
| // eslint-disable-next-line react-hooks/exhaustive-deps |
There was a problem hiding this comment.
maybe we should just add missing deps to array instead of adding
// eslint-disable-next-line react-hooks/exhaustive-deps ?
Does this cause any issue?
AdamKniec
approved these changes
Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… and request params preparation