Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Ref https://github.com/TheThingsIndustries/lorawan-stack-support/issues/929
Changes
ids
and{created,updated}_at
fields when getting the device from AS, JS and NSids
either match between the devices or are not presentTesting
Application https://eu1.cloud.thethings.network/console/applications/migrate-without-joineui contains a device registered without the JoinEUI that I attempted to export. The device was exported successfully.
Regressions
n/a
Notes for Reviewers
I attached other bugfix commits that otherwise would only be added in #65
Current solution only checks if the fields match and considers empty (
""
) fields matching any other field. This could be left for now or handled in 2 ways:a
andb
there aredst
destination andsrc
source identifiersdst
ids overwrite emptysrc
ids so that the fields that would be overwritten by an empty value won't be overwrittenpaths
so that when thesrc
value is empty it is removed from thepaths
and then can be removed post-validationChecklist
CHANGELOG.md
.