Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve source configuration #70

Merged
merged 7 commits into from
Apr 24, 2023
Merged

Improve source configuration #70

merged 7 commits into from
Apr 24, 2023

Conversation

happyRip
Copy link
Member

@happyRip happyRip commented Apr 13, 2023 •
edited
Loading

Summary

Ref #56

This PR is meant to implement improved config that is going to be used by both CLI redesign proposals.
It was mostly extracted from #65

Changes

  • Tie flags to struct fields to stop referencing flags by strings.
  • Update copyrights year

Testing

local

Regressions

...

Notes for Reviewers

...

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Documentation: Relevant documentation is added or updated.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.

@happyRip happyRip added this to the 2023 Q2 milestone Apr 13, 2023
@happyRip happyRip self-assigned this Apr 13, 2023
@happyRip happyRip force-pushed the feature/improve-config branch 3 times, most recently from 625701c to dc4b27e Compare April 13, 2023 17:12
@happyRip happyRip mentioned this pull request Apr 17, 2023
Merged
3 tasks
@happyRip happyRip marked this pull request as ready for review April 18, 2023 15:08
adriansmares
adriansmares approved these changes Apr 21, 2023
View reviewed changes
Copy link
Contributor

@adriansmares adriansmares left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has this been tested (at least v3 to v3) ?

@happyRip
Copy link
Member Author

Has this been tested (at least v3 to v3) ?

Yes, it was tested locally with ttnv3 source.
@adriansmares

@happyRip happyRip merged commit 5b1bde1 into master Apr 24, 2023
@happyRip happyRip deleted the feature/improve-config branch April 24, 2023 13:36
@happyRip happyRip linked an issue May 1, 2023 that may be closed by this pull request
Migration tool CLI redesign #56
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adriansmares adriansmares adriansmares approved these changes

@johanstokking johanstokking Awaiting requested review from johanstokking johanstokking is a code owner

Assignees

@happyRip happyRip

Labels
None yet
Projects
None yet
Milestone
2023 Q2
Development

Successfully merging this pull request may close these issues.

Migration tool CLI redesign
2 participants
@happyRip @adriansmares