Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change help text to display correct addresses #69

Merged
merged 1 commit into from
Feb 17, 2020

Conversation

phummel
Copy link
Contributor

@phummel phummel commented Feb 16, 2020

While the Data Lab Sim module auto adjusts with MMIO address range, the help text address values are not updated accordingly. This fixes the help text to show the updated address values.

@TheThirdOne
Copy link
Owner

What auto adjustment are you referring to? As the values you are printing are static and final, they shouldn't be able to change during program execution.

Can you give me a scenario where the PR actually changes what the displayed help content is?

@phummel
Copy link
Contributor Author

phummel commented Feb 17, 2020

The text in the help for Digital Lab Sim has hard coded values for memory addresses. These are correct if the Default memory configuration is used. If I switch to either of the compact memory configurations, the addresses the Digital Lab Sim tool is connected to change to match accordingly. However, the text in the help will still say 0xFFFF0010 instead of 0x00007F10. This change matches the text from the Keyboard and Display Simulator tool that updates with the memory configuration changes.

@TheThirdOne TheThirdOne merged commit 348b494 into TheThirdOne:master Feb 17, 2020
@TheThirdOne
Copy link
Owner

Ah, I missed thinking about restarting and relying on the setting being saved from the last launch.

I have merged your contribution in and made DigitalLabSim also update according to the memory configuration on launch of the tool. Thanks for the contribution.

Has Cal Poly been using the compact memory configuration? I have been thinking about making changes to the way memory configurations work so if I would like to know how yall are using it so I can make sure an update wouldn't break anything.

@phummel
Copy link
Contributor Author

phummel commented Feb 17, 2020

We have just refreshed a course switching to the RISC-V, and so we are working out what tools to use. In the course we implement our own single-cycle RISC-V (RV32i) on an FPGA. I have been using RARS exclusively, so I appreciate the work you have put into this. The memory configuration does not match the hardware we implement in the course, so I created a separate build for my classes with updated addresses. The compact configuration is close, but it was easier for students if everything matched exactly.

@TheThirdOne
Copy link
Owner

In case you are unaware, Ripes just released a new version that can simulate a single-cycle or 5 stage processor. Given the RARS, only simulates at the instruction level, I would think Ripes would fill in an important role in teaching the implementation of a RISC-V CPU.

@phummel phummel deleted the patch-1 branch December 18, 2020 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants