-
Notifications
You must be signed in to change notification settings - Fork 230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added pseudo op for jalr format used Hennesy&Patterson #81
Conversation
It does appear that gcc also supports this so I think it's reasonable to support it. With the one issue of Thanks for jumping in to add this. |
ahh thanks, I didn't fully understand the pseudo ops file format :-) I just updated my branch |
It definitely is a little confusing and the comments are actually out of date. The only reason I noticed is because I work with the assembler code. I actually don't see what you changed by the force push. I only see the commit and signature change. |
Unfortunately "Computer Organization and Design RISC-V Edition" use in their examples a non-standard format for jalr. To simply copy and paste their programs, add this pseudo op.
yeah, I forgot to add the real change ... somehow it resulted still in a new commit, what confused me. It should be really fixed now. |
I suspect you made the first commit on Github, and then made the change on a local repo. That would result in the two commits being different because one was signed and the other was not. Anyway it looks good now. |
Wow! I think I commented on this a few weeks ago. I didn't expect you to actually add it. Thanks a lot! |
@fudgenuggets12, You should be grateful to BenjaminBeichler. Without him this would not have gotten added; I didn't know if this was a common format. I did ask you at the time where you had seen it formatted like that.
If you had told me that Patterson and Hennessy wrote it like that, I would have added it then. Because you additionally were concerned about why your program was infinitely looping, I explained why rather than probe you for information about the format. If you notice something off in the future, a little bit of context can help get me to actually add something. I don't teach students RISC-V assembly and don't own a copy of the Patterson and Hennessy RISC-V edition so I have a substantial blind spot with regards to what a lot of users want. |
Unfortunately "Computer Organization and Design RISC-V Edition" use in their examples a non-standard format for jalr. To simply copy and paste their programs, add this pseudo op.