Skip to content

Commit

Permalink
fix(ios): missing notification controls when enabled from start (#3898)
Browse files Browse the repository at this point in the history
  • Loading branch information
KrzysztofMoch authored Jun 12, 2024
1 parent cfb5b1c commit 2d793db
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
8 changes: 4 additions & 4 deletions examples/basic/ios/Podfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -935,7 +935,7 @@ PODS:
- React-Mapbuffer (0.74.1):
- glog
- React-debug
- react-native-video (6.1.2):
- react-native-video (6.2.0):
- DoubleConversion
- glog
- hermes-engine
Expand All @@ -949,15 +949,15 @@ PODS:
- React-featureflags
- React-graphics
- React-ImageManager
- react-native-video/Video (= 6.1.2)
- react-native-video/Video (= 6.2.0)
- React-NativeModulesApple
- React-RCTFabric
- React-rendererdebug
- React-utils
- ReactCommon/turbomodule/bridging
- ReactCommon/turbomodule/core
- Yoga
- react-native-video/Video (6.1.2):
- react-native-video/Video (6.2.0):
- DoubleConversion
- glog
- hermes-engine
Expand Down Expand Up @@ -1422,7 +1422,7 @@ SPEC CHECKSUMS:
React-jsitracing: 3de522f8f794dccd3c54af9160dc992ee65bd494
React-logger: 7e7403a2b14c97f847d90763af76b84b152b6fce
React-Mapbuffer: c5844bf3c2206f5475c0fc2340a89b049ea23c97
react-native-video: edecf23162492d4f41f96ff167684fc0507ca63a
react-native-video: 59f262a2d87c998b747ca1f031efb6eba1c156b5
React-nativeconfig: 21d89c65ca39875fad2c5c465e0e013e514eba21
React-NativeModulesApple: e2e180dae4486b2978fcf3564cc4c8de4b453a68
React-perflogger: 3d31e0d1e8ad891e43a09ac70b7b17a79773003a
Expand Down
4 changes: 2 additions & 2 deletions ios/Video/RCTVideo.swift
Original file line number Diff line number Diff line change
Expand Up @@ -1104,6 +1104,8 @@ class RCTVideo: UIView, RCTVideoPlayerViewControllerDelegate, RCTPlayerObserverH

@objc
func setShowNotificationControls(_ showNotificationControls: Bool) {
_showNotificationControls = showNotificationControls

guard let player = _player else {
return
}
Expand All @@ -1113,8 +1115,6 @@ class RCTVideo: UIView, RCTVideoPlayerViewControllerDelegate, RCTPlayerObserverH
} else {
NowPlayingInfoCenterManager.shared.removePlayer(player: player)
}

_showNotificationControls = showNotificationControls
}

@objc
Expand Down

0 comments on commit 2d793db

Please sign in to comment.