Skip to content

Commit

Permalink
fix(android): remove remaining ad view when zapping (#3786)
Browse files Browse the repository at this point in the history
* perf: ensure we do not provide callback to native if no callback provided from app

* chore: rework bufferConfig to make it more generic and reduce ReactExoplayerView code size

* chore: improve issue template

* fix(android): avoid video view flickering at playback startup

* fix(android): ensure adsLoader is well release if unused
  • Loading branch information
freeboub authored May 16, 2024
1 parent 8ee4bcc commit 324b461
Showing 1 changed file with 5 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -712,6 +712,11 @@ private void initializePlayerSource(ReactExoplayerView self, DrmSessionManager d
.setLocalAdInsertionComponents(unusedAdTagUri -> adsLoader, exoPlayerView);
DataSpec adTagDataSpec = new DataSpec(adTagUrl);
mediaSourceWithAds = new AdsMediaSource(videoSource, adTagDataSpec, ImmutableList.of(srcUri, adTagUrl), mediaSourceFactory, adsLoader, exoPlayerView);
} else {
if (adTagUrl == null && adsLoader != null) {
adsLoader.release();
adsLoader = null;
}
}
MediaSource mediaSource;
if (mediaSourceList.size() == 0) {
Expand Down

0 comments on commit 324b461

Please sign in to comment.