fix(ios): fix wrong fullscreen method definition (#3338)

TheWidlarzGroup · Nov 8, 2023 · 7f49b56 · 7f49b56
1 parent 6df0f7d
commit 7f49b56
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 10 deletions.
diff --git a/ios/Video/RCTVideo.swift b/ios/Video/RCTVideo.swift
@@ -1085,11 +1085,11 @@ class RCTVideo: UIView, RCTVideoPlayerViewControllerDelegate, RCTPlayerObserverH
         _resouceLoaderDelegate?.setLicenseResultError(error, licenseUrl)
     }
 
-    func dismissFullscreenPlayer(_ error:String!) {
+    func dismissFullscreenPlayer() {
         setFullscreen(false)
     }
 
-    func presentFullscreenPlayer(_ error:String!) {
+    func presentFullscreenPlayer() {
         setFullscreen(true)
     }
 

diff --git a/ios/Video/RCTVideoManager.m b/ios/Video/RCTVideoManager.m
@@ -81,8 +81,9 @@ @interface RCT_EXTERN_MODULE(RCTVideoManager, RCTViewManager)
 RCT_EXTERN_METHOD(setPlayerPauseState:(nonnull NSNumber *)paused
                  reactTag:(nonnull NSNumber *)reactTag)
 
-RCT_EXTERN_METHOD(presentFullscreenPlayer
-                 reactTag:(nonnull NSNumber *)reactTag)
+RCT_EXTERN_METHOD(presentFullscreenPlayer:(nonnull NSNumber *)reactTag)
+
+RCT_EXTERN_METHOD(dismissFullscreenPlayer:(nonnull NSNumber *)reactTag)
 
 RCT_EXTERN_METHOD(dismissFullscreenPlayer
                  reactTag:(nonnull NSNumber *)reactTag)

diff --git a/ios/Video/RCTVideoManager.swift b/ios/Video/RCTVideoManager.swift
@@ -48,25 +48,25 @@ class RCTVideoManager: RCTViewManager {
         })
     }
 
-    @objc(dismissFullscreenPlayer:reactTag:)
-    func dismissFullscreenPlayer(error: NSString, reactTag: NSNumber) -> Void {
+    @objc(dismissFullscreenPlayer:)
+    func dismissFullscreenPlayer(_ reactTag: NSNumber) -> Void {
         bridge.uiManager.prependUIBlock({_ , viewRegistry in
             let view = viewRegistry?[reactTag]
             if !(view is RCTVideo) {
                 RCTLogError("Invalid view returned from registry, expecting RCTVideo, got: %@", String(describing: view))
             } else if let view = view as? RCTVideo {
-                view.dismissFullscreenPlayer(error as String)
+                view.dismissFullscreenPlayer()
             }
         })
     }
-    @objc(presentFullscreenPlayer:reactTag:)
-    func presentFullscreenPlayer(error: NSString, reactTag: NSNumber) -> Void {
+    @objc(presentFullscreenPlayer:)
+    func presentFullscreenPlayer(_ reactTag: NSNumber) -> Void {
         bridge.uiManager.prependUIBlock({_ , viewRegistry in
             let view = viewRegistry?[reactTag]
             if !(view is RCTVideo) {
                 RCTLogError("Invalid view returned from registry, expecting RCTVideo, got: %@", String(describing: view))
             } else if let view = view as? RCTVideo {
-                view.presentFullscreenPlayer(error as String)
+                view.presentFullscreenPlayer()
             }
         })
     }