Skip to content

Commit

Permalink
fix(sample): boot failure on emulator (#4016)
Browse files Browse the repository at this point in the history
* fix: disable coreLibraryDesugaringEnabled by default
  • Loading branch information
freeboub authored Jul 18, 2024
1 parent 9f38216 commit ffbc977
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 10 deletions.
6 changes: 4 additions & 2 deletions examples/basic/android/app/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -83,8 +83,10 @@ android {
namespace "com.videoplayer"

compileOptions {
// These options are necessary to be able to build fro source
coreLibraryDesugaringEnabled true
// These options are necessary to be able to build from source
// coreLibraryDesugaringEnabled is mandatory to be able to build exoplayer from source
// uncomment this line if you want to build from source
// coreLibraryDesugaringEnabled true
sourceCompatibility JavaVersion.VERSION_11
targetCompatibility JavaVersion.VERSION_11
}
Expand Down
8 changes: 0 additions & 8 deletions examples/basic/src/VideoPlayer.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ import Video, {
type OnPlaybackRateChangeData,
type OnVideoTracksData,
type ReactVideoSource,
type TextTracks,
type VideoTrack,
type SelectedTrack,
type SelectedVideoTrack,
Expand All @@ -37,13 +36,6 @@ import {type AdditionalSourceInfo} from './types';
import {bufferConfig, srcList, textTracksSelectionBy} from './constants';
import {Overlay, toast} from './components';

type AdditionnalSourceInfo = {
textTracks: TextTracks;
adTagUrl: string;
description: string;
noView: boolean;
};

type Props = NonNullable<unknown>;

const VideoPlayer: FC<Props> = ({}) => {
Expand Down

0 comments on commit ffbc977

Please sign in to comment.