-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accessing view manager configs directly off UIManager via UIManager['RCTVideo'] is no longer supported. Use UIManager.getViewManagerConfig('RCTVideo') instead. #1463
Comments
Fix for Issue, directly accessing NativeModules.UIManager is no longer supported. Propose to add import to UIManager directly from 'react-native' module on top and change the code from NativeModules.UIManager.RCTVideo.~~~ to UIManager.getViewManagerConfig('RCTVideo').~~~ as suggested from react-native's warning.
I'm getting just a warning for this same issue, made a fix for it on my own device. e830128 |
please somebody update this ? |
@jakks-team reason is correct but you have to update from the node_modules. It must be updated from the author. |
any guide on how to update from node_modules? |
@jakks-team You should submit a pull request with your change. Here are the guidelines for this specific project: https://github.com/react-native-community/react-native-video/blob/master/.github/PULL_REQUEST_TEMPLATE.md And here are instructions for creating a pull request on Github: https://help.github.com/articles/creating-a-pull-request/ Hope that helps! |
I think @omercanyigit means installing git commit as npm package. ¯_(ツ)_/¯ I've tested this commit and it works on Android and iOS. Thank you so much @jakks-team ! This is a critical bug fix! |
When will this commit @jakks-team ? |
I'm not sure. And I think someone should close this issue and check on the PR to have someone with write access to master branch to merge this there. |
According to the PR @jakks-team linked above, this is fixed with 4.4.0, but I'm still seeing this issue on that version. I see a different fix than the one that jakks-team presented in my node_modules 4.4.40
|
I can not use the library. It is saying that
" Accessing view manager configs directly off UIManager via UIManager['RCTVideo'] is no longer supported. Use UIManager.getViewManagerConfig('RCTVideo') instead. "
what can i do?
Thanx
The text was updated successfully, but these errors were encountered: