-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iOS Fullscreen with Controls Crash #1568
Comments
@jonas-arkulpa can you try this fix in my master branch before I do a pull request |
@ashnfb Thx for the really fast response. With the change our implementation does not crash if the With active The grey background is the video. Tested on an iPhone X. |
@jonas-arkulpa @cobarx iOS 11+ has much better methods for method-based entry into fullscreen mode. The code in the repo is much more complex than it needs to be because of legacy iOS support. |
@kaybutter Do you have the time to test this the following weeks? |
@jonas-arkulpa Yup. Should find some time next week :) |
Sorry, haven't had time to look at this yet. Will try my best to get to it quickly. |
@ashnfb Sorry that it took so long. I've tried using your branch. I noticed that the video refuses the play in fullscreen now, if I set |
@ashnfb any update on this? I have an issue with fullscreen via |
We have this issue too when setting fullscreen via Simulator/Device (iOS)
I've setup a test repo to reproduce and debug : https://github.com/4AllDigital/RNV-iOS I'm happy to do any work/testing on this, but Im not an Objective-C developer and it seems that the issue is on that side, possibly around https://github.com/react-native-community/react-native-video/blob/master/ios/Video/RCTVideo.m#L1257, but I'd be guessing. |
… specific conditionals 🐛 see: TheWidlarzGroup#1568
Hi @joemewes, I've been away for 2 months, and haven't been looking into react-native-video for some time. I will try and have a look in the next few weeks at this issue if I can find the time; I recall it being pretty ugly to fix because of legacy iOS APIs. Apologies that I can't help more immediately. |
@ashnfb no worries. That's great and no stress about timings. I still think open-source projects and maintainers amazing! lol. |
Hello all, this is also happening for us, but on an iPad 7th gen running iOS 13.1. Our (stripped-back for clarity) implementation:
Thanks for your time :) EDIT: rolling back to 3.1.0 fixed this for us. |
+1 here. |
Any update on this change? I am getting the same error. I am trying to make the video automatically go full screen if the user switches to landscape during playback. |
I have this issue too, with react-native-video version 5.0.2. |
i have the same error on IOS, |
hello can you specify your source ? |
same issue with react-native-video version@5.0.2 |
I have the same issue in the TVOS app, any update? |
to fullscreen work fine you need set absoluteFill (top:0, bottom:0, left:0, right:0) in Video component |
yes, I did it already. I'm facing the same issue which was mentioned by @joemewes in his earlier comment #1568 (comment) |
I've observed one thing here which allows playing video on fullscreen mode, I hope it will help others use
As you can see here I'm not doing anything here with this event but fullscreen working perfectly once I mentioned this event |
It's annoying but for now I'm just handling it like: <Video
controls={Platform.OS === 'android' || !fullScreen}
// ...other props
> where Works for me on version 5.1.1, but since the |
I can't even see the log information here using the same code. It seems onFullscreenPlayerDidDismiss() on my ios simulator device does not work at all. |
Does anyone have a solution for this? I am using and PR to have fullscreen for Android so I can't rollback to 3.1.0. Edit: Current solution
|
@ashnfb @cobarx
Current behavior
The following change crashes our current implementation on iOS:
https://github.com/react-native-community/react-native-video/pull/1441/files#diff-42e8804735be64e84d6dd1fb103210a1R566
We display the video in full screen as soon as it is loaded.
After updating this implementation crashes.
A fix is not urgent for us, as we do not need the controls in non fullscreen mode on iOS.
As a workaround we just disable the controls on iOS, which resolves the issue.
Reproduction steps
<Video source={this.props.source} resizeMode='contain' paused={false} repeat={false} controls={true} onLoad={() => this.player && this.player.presentFullscreenPlayer()} ref={this.handleRef} style={fullscreen} />
Additional info: We render the video in a react navigation dialog.
Expected behavior
It does not crash.
Platform
The text was updated successfully, but these errors were encountered: