Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Controls visible callback #2686

Closed
brantleyenglish opened this issue May 18, 2022 · 3 comments · Fixed by #3925
Closed

Controls visible callback #2686

brantleyenglish opened this issue May 18, 2022 · 3 comments · Fixed by #3925
Labels

Comments

@brantleyenglish
Copy link

Feature Request

Callback for when controls show and hide.
Similar to onShowControls and onHideControls on react-native-video-controls.

Why it is needed

I need to add a custom button to the video controls. This callback would allow hiding and showing it.

I looked at react-native-video-controls and react-native-media-controls for solving this need, but I also need subtitle support that react-native-video has baked in.

@coucoseth
Copy link

just a question here, how can i hide/show my custom controls

@ashnfb
Copy link
Contributor

ashnfb commented Jun 19, 2024

Implemented here for Android:
https://github.com/ashnfb/react-native-video

This isn't possible for iOS without a hack, as there's no public methods provided by Apple

@freeboub
Copy link
Collaborator

implementation for android will be included in 6.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants