feat(android): add onControlsVisiblityChange
#3925
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashnfb
changed the title
|
@freeboub, any idea how I can fix this ESLint error? I've tried a few approaches |
|
@ashnfb did you try : "yarn lint" ? |
freeboub
reviewed
Jun 20, 2024
|
I added 1 minor comment, but code looks good ! Thank you |
KrzysztofMoch
changed the title
onControlsVisiblityChange
|
@KrzysztofMoch @freeboub, corrections made. I haven't been involved in this project in a while, may I ask what steps are next? |
|
If all checks will be green, and @freeboub will approve it (as he requested change) - we can go with it and merge it |
freeboub
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
A callback event for when the Android Exoplayer controls show and hide.
Issue request: #2686
Motivation
Since the Android video player LegacyControls have limited controls (play, pause, rewind, forward, scrubber, etc., and do not provide an interface for changing the Captions or Audio of a stream, or implementing additional buttons), having an event allows a consumer class to overlay buttons / information at the same time as controls are shown.
Changes
Adds onControlsVisibilityChange to VideoEventEmitter
Adds a visibility listener to the playerControlView in ReactExoplayerview to trigger the new event
Not available for iOS, due to no public methods for monitoring native control visibility
Test plan