-
-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(android): video flickering add playback start #3746
fix(android): video flickering add playback start #3746
Conversation
…oplayerView code size
…ideo # Conflicts: # android/src/main/java/com/brentvatne/exoplayer/ReactExoplayerViewManager.java # src/Video.tsx
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't like that we need to use such workarounds...
LGTM ✅
Yes, but the issue is quite complicated, The delay is only 15ms, so 1 additional frame for user perspective, I think this will be seemless, so it is acceptable. |
I want to make release, so I will merge this |
…Group#3746)" This reverts commit b1cd52b. s
Summary
Avoid flickering when video playback starts on android
Motivation
Fix: #3740
This issue gives a very bad quality feedback...
Changes
I fix few warning and did few clean up but the main change is to delay the shutterView removal by 15 ms
Test plan
Can be tested in the sample