Revert "fix(android): video flickering add playback start (#3746)" #3748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Group#3746)" This reverts commit b1cd52b. s
|
Are you sure this is not working? I am testing it with example and it's working very well 🤔 |
I am on it to test, I will get back to you in a while |
|
@KrzysztofMoch I tested out a new release @6.0.0-rc.1 again, Let me share the recorded video of this, it didn't load the video, while the app is in production on both stores with the name Nooberly with version 6.0.0-rc.0, it is working fine but has a flickering issue WhatsApp.Video.2024-05-09.at.2.36.16.PM.mp4 |
|
I checked this PR , now the video is loading perfectly but has old flickering issue .I am using React-Native version o.71.14, Let me know If you need more info from my side |
|
We need to do more investigation on this issue - let's revert |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit b1cd52b.
Summary
Revert the video flickering PR, as changes related to shutterView never loading the video
Motivation
this was causing issue, it was never letting the player to load the video
Changes
Test plan
Will test it