fix(ios): ensure onBandwidthUpdate is reported only when value change #4149
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freeboub
commented
Sep 5, 2024
seyedmostafahasani
approved these changes
Sep 5, 2024
|
@KrzysztofMoch any clue on this build issue ? |
…o into fix/iosBandwidthUpdateFlood
…ct-native-video into fix/iosBandwidthUpdateFlood
|
Please recheck the changes. OnBandwidthUpdate works on ios on mp4 file but is not working on HLS .m3u8 https://rbmn-live.akamaized.net/hls/live/590964/BoRB-AT/master_928.m3u8 on mp4, it indeed returns a bitrate. however, onBandwidthUpdate always returns -1 on HLS files. Anything I'm missing here @freeboub @KrzysztofMoch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
while testing: #4146 on ios I saw the onBandwidthUpdate flooding app with the same value.
Motivation
do not report multiple time the same value with onBandwidthUpdate
complementary fix for: #4139
Changes
Just avoid reporting multiple times the same value
Test plan
can be tested with the sample