Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ios): ensure onBandwidthUpdate is reported only when value change #4149

Merged
merged 6 commits into from
Sep 6, 2024
Merged

fix(ios): ensure onBandwidthUpdate is reported only when value change #4149

Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
059a3e5
fix(ios): ensure onBandwidthUpdate is reported only when value change
freeboub Sep 5, 2024
4f0589a
chore: fix linter
freeboub Sep 5, 2024
b42e354
chore(ios): comment code
freeboub Sep 5, 2024
8039a8c
Merge branch 'master' of github.com:TheWidlarzGroup/react-native-vide…
freeboub Sep 6, 2024
3f27e35
Merge branch 'fix/iosBandwidthUpdateFlood' of github.com:freeboub/rea…
freeboub Sep 6, 2024
445b273
chore: fix PodFile.lock
freeboub Sep 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions ios/Video/RCTVideo.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,7 @@ class RCTVideo: UIView, RCTVideoPlayerViewControllerDelegate, RCTPlayerObserverH
private var _presentingViewController: UIViewController?
private var _startPosition: Float64 = -1
private var _showNotificationControls = false
private var _lastBitrate = -2.0
freeboub marked this conversation as resolved.
Show resolved Hide resolved
freeboub marked this conversation as resolved.
Show resolved Hide resolved
private var _pictureInPictureEnabled = false {
didSet {
#if os(iOS)
Expand Down Expand Up @@ -1659,9 +1660,11 @@ class RCTVideo: UIView, RCTVideoPlayerViewControllerDelegate, RCTPlayerObserverH
guard let accessLog = (notification.object as? AVPlayerItem)?.accessLog() else {
return
}

guard let lastEvent = accessLog.events.last else { return }
onVideoBandwidthUpdate?(["bitrate": lastEvent.indicatedBitrate, "target": reactTag])
if lastEvent.indicatedBitrate != _lastBitrate {
_lastBitrate = lastEvent.indicatedBitrate
onVideoBandwidthUpdate?(["bitrate": _lastBitrate, "target": reactTag])
}
}

func handleTracksChange(playerItem _: AVPlayerItem, change _: NSKeyValueObservedChange<[AVPlayerItemTrack]>) {
Expand Down
Loading