Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove obsolete metadata code that shouldn't have been included #1040

Merged
merged 1 commit into from
May 29, 2018
Merged

Remove obsolete metadata code that shouldn't have been included #1040

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 1 addition & 10 deletions android-exoplayer/src/main/java/com/brentvatne/exoplayer/ExoPlayerView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,6 @@
import com.google.android.exoplayer2.PlaybackParameters;
import com.google.android.exoplayer2.SimpleExoPlayer;
import com.google.android.exoplayer2.Timeline;
import com.google.android.exoplayer2.metadata.Metadata;
import com.google.android.exoplayer2.metadata.MetadataRenderer;
import com.google.android.exoplayer2.source.TrackGroupArray;
import com.google.android.exoplayer2.text.Cue;
import com.google.android.exoplayer2.text.TextRenderer;
Expand Down Expand Up @@ -101,7 +99,6 @@ public void setPlayer(SimpleExoPlayer player) {
this.player.setVideoListener(null);
this.player.removeListener(componentListener);
this.player.setVideoSurface(null);
this.player.setMetadataOutput(componentListener);
}
this.player = player;
shutterView.setVisibility(VISIBLE);
Expand All @@ -114,7 +111,6 @@ public void setPlayer(SimpleExoPlayer player) {
player.setVideoListener(componentListener);
player.addListener(componentListener);
player.setTextOutput(componentListener);
player.setMetadataOutput(componentListener);
}
}

Expand Down Expand Up @@ -168,7 +164,7 @@ private void updateForCurrentTrackSelections() {
}

private final class ComponentListener implements SimpleExoPlayer.VideoListener,
TextRenderer.Output, ExoPlayer.EventListener, MetadataRenderer.Output {
TextRenderer.Output, ExoPlayer.EventListener {

// TextRenderer.Output implementation

Expand Down Expand Up @@ -232,11 +228,6 @@ public void onPlaybackParametersChanged(PlaybackParameters params) {
// Do nothing
}

@Override
public void onMetadata(Metadata metadata) {
Log.d("onMetadata", "onMetadata");
}

@Override
public void onSeekProcessed() {
// Do nothing.
Expand Down