Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instead of crashing, show a warning and return #1246

Merged
merged 3 commits into from
Feb 19, 2019
Merged

Instead of crashing, show a warning and return #1246

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c375077
Instead of crashing, show a warning and return
niklassaers Sep 19, 2018
865db71
Doh, should of course be AND, not OR
niklassaers Sep 20, 2018
075dfba
Only check for an empty source
cobarx Feb 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ios/Video/RCTVideo.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,6 +436,10 @@ - (void)playerItemForSource:(NSDictionary *)source withCallback:(void(^)(AVPlaye
bool isAsset = [RCTConvert BOOL:[source objectForKey:@"isAsset"]];
NSString *uri = [source objectForKey:@"uri"];
NSString *type = [source objectForKey:@"type"];
if (!uri || [uri isEqualToString:@""]) {
DebugLog(@"Could not find video URL in source '%@'", source);
return;
}

NSURL *url = isNetwork || isAsset
? [NSURL URLWithString:uri]
Expand Down