Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fix android subtitle issue caused by using rawdatasource #1373

Merged
merged 1 commit into from
Dec 31, 2018
Merged

[WIP] Fix android subtitle issue caused by using rawdatasource #1373

merged 1 commit into from
Dec 31, 2018

Conversation

reime005
Copy link
Contributor

@reime005 reime005 commented Dec 9, 2018

I could reproduce the issue described in #1371 and fixed the issue. I'm not sure if this breaks some other functionality.

When testing, I received the following error message:

E/ExoPlayerImplInternal( 5534): Source error.
E/ExoPlayerImplInternal( 5534): com.google.android.exoplayer2.upstream.RawResourceDataSource$RawResourceDataSourceException: com.google.android.exoplayer2.upstream.RawResourceDataSource$RawResourceDataSourceException: URI must use scheme rawresource

Tested on Android Emulator API 28 and 18. Release and Debug builds.

Project used: https://github.com/reime005/VideoPlayerTest

Fixes issue #1371

@cobarx
Copy link
Contributor

cobarx commented Dec 13, 2018

@reime005 I see you've got a WIP tag on this and don't want to test / merge until you give the go ahead. Do you want to do any more testing before I test and merge this?

@reime005
Copy link
Contributor Author

I've tested this a lot in the last days, so you can test and merge this PR

@cobarx
Copy link
Contributor

cobarx commented Dec 31, 2018

Works great! Thanks so much for tracking this down and fixing it.

@cobarx cobarx merged commit 7837c39 into TheWidlarzGroup:master Dec 31, 2018
beauner69 pushed a commit to beauner69/react-native-video that referenced this pull request Oct 10, 2019
…e-fix

[WIP] Fix android subtitle issue caused by using rawdatasource

(rebased from commit 7837c39)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants