Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add iOS and Android basic DRM support #1445
Add iOS and Android basic DRM support #1445
Changes from 117 commits
5154cb6
fee5c0e
51b0085
8d62b78
8753111
ea7601e
0755c8c
a665eb1
ad9ad49
06bb389
7ae01b3
870e007
8506567
347d525
fd7858e
b61e02a
dcbf469
29f5ad3
8f29f85
e8da925
7b63331
34654f7
bceefc6
e65aa2c
d2c2cdc
d262801
b66d345
8d360fd
69f7f38
aa07618
9160c0b
f1d97c1
7367a90
bcd9c7a
e3801d6
d2f9641
4d2ffd2
cad76c1
13e7d1c
f2f33a8
4afb12b
8013450
02fd425
e11fe62
2391747
3cfdc7e
eed8619
cdfb630
6cfcf3b
a89ac0c
a8cba98
7b1409c
3110864
7ccd4b6
2713e8f
56cbf9c
ab900e5
b813a84
7836797
403b01e
397d14e
4e4d8b1
d5f1813
c0cd82e
9b3e4e7
477607b
5f6425f
b8ccec8
56d2af5
4dd1c73
d759e97
e5cd51a
d981f80
e7f1732
801dce4
fd16a93
59b541c
5b92ea0
a7780f9
decb56e
9df4f89
0c87b78
9b5ced2
6e3e653
24730ed
5725c62
4d12d1d
4210929
3b952dc
1b680c2
a22bf45
ce4dedf
8818b9a
bdc599d
a296fd9
2fc3b77
2d0e402
9fa4046
88c5541
91f200b
f6bc13e
fb3175f
4c4899b
a48fb69
c123d86
e6710f3
e9c978c
7525d4a
f484bd8
395b9b7
d266b32
03b2d4d
62166a2
725a15c
c7a8a25
8c40aaf
32748d5
8c25828
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't look like you have a way to specify ClearKey keys, so we shouldn't mention it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have never work with clearkey, but if we get a sample stream for that, maybe it can be implemented, as exoplayer seems to support it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
data.spc
is empty in JavaScriptCore environment 🤷♂ I'm checkingdata.spcBase64
as workaround.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Totally I've noticed this last Friday, I don't know why but data.spc is empty in JavaScriptCore except when JS Remote Debugger is enabled 🤔
I had to implement a fallback using the B64 version of spc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will take a look at this, thank you so much! To be honest I always checked with debugger on, so I didn't expect this to come