Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw an error instead of crashing app when video source is empty #1478

Merged
merged 1 commit into from
Feb 19, 2019
Merged

Throw an error instead of crashing app when video source is empty #1478

merged 1 commit into from
Feb 19, 2019

Commits on Feb 11, 2019

  1. Throw an error instead of crashing app when video source is empty 

    If an undefined source is accidentally loaded in react-native-video a fatal error SIGABRT will happen and crash the application. This is very difficult to debug since there's apparently no relation between this crash and react-native-video. So this change checks if the URI is empty and, if it is, it throws an error, allowing the user to find out early about the issue.

https://cloud.githubusercontent.com/assets/5795227/20283860/08223ba6-aabb-11e6-9fdc-d12d32b3aa9a.png
    @laurent22
    laurent22 authored Feb 11, 2019
    Configuration menu
    Copy the full SHA
    891add6 View commit details
    Browse the repository at this point in the history