Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change compileOnly to implementation on gradle (for newer gradle versions and react-native 0.59 support) #1592

Merged
merged 3 commits into from
Jun 20, 2019

Conversation

yjb94
Copy link
Contributor

@yjb94 yjb94 commented May 24, 2019

Thanks for opening a PR!
Since this is a volunteer project and is very active, anything you can do to reduce the amount of time needed to review and merge your PR is appreciated.
The following steps will help get your PR merged quickly:

Update the documentation

If you've added new functionality, update the README.md with an entry for your prop or event.
The entry should be inserted in alphabetical order.

Update the changelog

After you open the PR, update the CHANGELOG.md file with an entry pointing to your PR.

Provide an example of how to test the change

If the PR requires special testing setup provide all the relevant instructions and files. This may include a sample video file or URL, configuration, or setup steps.

Focus the PR on only one area

Testing multiple features takes longer than isolated changes and if there is a bug in one feature, prevents the other parts of your PR from getting merged until it gets fixed.
If you're touching multiple different areas that aren't related, break the changes up into multiple PRs.

Describe the changes

Add a note describing what your PR does. If there is a change to the behavior of the code, explain why it needs to be updated.

#1585
bug fixed for this issue

@marioot
Copy link

marioot commented Jun 14, 2019

Anything else required for this to get merged?

@n1ru4l
Copy link
Contributor

n1ru4l commented Jun 14, 2019

Is this backwards compatible to react-native 0.58?

@CHaNGeTe
Copy link
Contributor

@n1ru4l despite of the title I think it is more related to android sdk / gradle version.
Maybe @cobarx knows more about this.
I will try also to ask on monday at work if it can introduce incompatibility, but I am seeing lots of libraries that have grandle with implementation.
https://stackoverflow.com/a/44493379

@CHaNGeTe CHaNGeTe changed the title react-native 0.59 support Change compileOnly to implementation on gradle (for newer gradle versions and react-native 0.59 support) Jun 20, 2019
@CHaNGeTe CHaNGeTe changed the base branch from master to release/4.4.2 June 20, 2019 05:26
@CHaNGeTe CHaNGeTe merged commit cad807d into TheWidlarzGroup:release/4.4.2 Jun 20, 2019
CHaNGeTe pushed a commit that referenced this pull request Jun 20, 2019
beauner69 pushed a commit to beauner69/react-native-video that referenced this pull request Oct 10, 2019
Change compileOnly to implementation on gradle (for newer gradle versions and react-native 0.59 support)

(rebased from commit cad807d)
beauner69 pushed a commit to beauner69/react-native-video that referenced this pull request Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants