Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing the call to observeValueForKeyPath:ofObject:change:context: … #1720

Merged
merged 3 commits into from
Sep 8, 2019
Merged

Removing the call to observeValueForKeyPath:ofObject:change:context: … #1720

merged 3 commits into from
Sep 8, 2019

Commits on Aug 20, 2019

  1. Removing the call to observeValueForKeyPath:ofObject:change:context: … 

    …on super from RCTVideo.

If the super class is not actually observing the key, the app will crash. Checking to see if
the super class responds to this selector doesn't solve this issue.

react-native-video github issue: TheWidlarzGroup#1515

Discussion about this particular problem: https://stackoverflow.com/questions/6574714/whats-wrong-with-this-observevalueforkeypathofobjectchangecontext-implement
    Nahuel Marisi committed Aug 20, 2019
    Configuration menu
    Copy the full SHA
    7a9081d View commit details
    Browse the repository at this point in the history

  2. Updated CHANGELOG to reflect bug fix in PR 1720

    Nahuel Marisi committed Aug 20, 2019
    Configuration menu
    Copy the full SHA
    923bc59 View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2019

  1. Merge branch 'master' into fix-NSInternalInconsistencyException

    @CHaNGeTe
    CHaNGeTe authored Sep 8, 2019
    Configuration menu
    Copy the full SHA
    9272678 View commit details
    Browse the repository at this point in the history